Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debugger: Use wxSearchCtrls instead of wxTextCtrl for address searching. #2798

Merged
merged 4 commits into from Oct 11, 2015

Conversation

lioncash
Copy link
Member

@lioncash lioncash commented Aug 3, 2015

Essentially the same thing, however wxSearchCtrls allow for transparent description text that fades away once the user inputs something (and comes back if the field is cleared).

e.g.

@shuffle2
Copy link
Contributor

shuffle2 commented Sep 4, 2015

plz2rebase

Doesn't make sense to flag these as errors, since someone might search for another address.
Aligns controls so that their widths remain the same with one another
@dolphin-emu-bot
Copy link
Contributor

FifoCI detected that this change impacts graphical rendering. Here are the behavior differences detected by the system:

  • find-mii on ogl-lin-nv: diff

automated-fifoci-reporter

@lioncash
Copy link
Member Author

@shuffle2 rebased

Tilka added a commit that referenced this pull request Oct 11, 2015
Debugger: Use wxSearchCtrls instead of wxTextCtrl for address searching.
@Tilka Tilka merged commit f3c8813 into dolphin-emu:master Oct 11, 2015
@lioncash lioncash deleted the search branch January 25, 2017 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants