Properly scan for OpenVPN TAP adapters #2832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handle errors correctly in SendFrame
|
|
||
| status = RegOpenKeyEx(HKEY_LOCAL_MACHINE, NETWORK_CONNECTIONS_KEY, 0, KEY_READ, &control_net_key); | ||
|
|
||
| if (status != ERROR_SUCCESS) | ||
| return false; | ||
|
|
||
| while (!found_all) | ||
| for (;; i++) |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
Is this change required because OpenVPN changed their driver, or some other reason? |
|
The registery on Windows 10 is different, making it unable to find the TAP adapters without this fix. Also the code was simply wrong. |
shuffle2
added a commit
that referenced
this pull request
Aug 12, 2015
Properly scan for OpenVPN TAP adapters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Properly scan for OpenVPN TAP adapters
and handle errors correctly in SendFrame.