DolphinQt: Rewrite 'About' dialog to match the new WX one. #2833
Conversation
|
With the Qt one, I think the right side of the dolphin should have a slight bit more padding on it. |
|
oh, also cc @MaJoRoesch |
| Thanks to hcs/destop for their GC ADPCM decoder.<br> | ||
| <br> | ||
| We are not affiliated with Nintendo in any way. GameCube and Wii are<br> trademarks of Nintendo. This emulator should not be used to play games<br>you do not legally own.</string> | ||
| <string><a href="https://github.com/dolphin-emu/dolphin/blob/master/license.txt">License</a> | <a href="https://github.com/dolphin-emu/dolphin/graphs/contributors">Authors</a> | <a href="https://forums.dolphin-emu.org/">Support</a></string> |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
I know that the reason "Dolphin" is slightly offset right in the WX version is because they couldn't get it to line up with the coding. Is this also the case with Qt or did you just want it to match WX exactly? |
|
I haven't taken a close look at this yet. Does it properly handle @2x on the logo? |
|
Also, the logo needs better padding around it. The text is way too tight next to it. |
|
DEFINITELY increase the padding around the logo, and increase the spacing between the lines. And you may want to reduce the size of the text that runs along the bottom, it's kind of using the enter horizontal width, which looks weird. |
No, I wanted it to look as good as possible, not just "match WX exactly".
Yes, the "Resources" class already handles
OK, will do. |
|
I think the copyright line in the WX version still looks a bit better as far as spacing and font size goes. Could you try to match that? |
|
Also in my original mockup I was looking to have it so the links were only underlined on mouseover but I think it was determined that wasn't possible with WX. Can that be done with Qt and if so would you considering adding it? For reference this was the look I was going for when this was first done:
|
waddlesplash
force-pushed
the
dolphin-qt
branch
from
807120a
to
40098b5
Compare
|
Better? |
Qt's CSS styling doesn't support "text-decoration", unfortunately. So, not easily. |
|
It could still use some more padding between the logo and the text... And the spacing between the rows of text is really really tight. Aaaand the license | support | authors looks better in WX, thanks to some extra spacing. The copyright text is good though! :P I guess the best advice I can give is to point to the WX version and say "do that"! It's one of the few pieces of the WX GUI that's actually been thoroughly reviewed and tweaked recently, so it's actually pretty good. EDIT: Btw, I don't know why, but your WX current image is kind of weird... the WX about window looks better on when I try it on Windows. Perhaps it's your distro? shrug
|
|
Aside from all the insane misalignment in KDE, you mean. 😛 |
|
I guess someone needs to upload a screenshot of this PR from windows (or a distro without alignment issues) then. Please don't make the dialup girl do it. :'( |
|
From a pure outsider POV, I have to disagree with you MaJoRoesch. I think the hierachy and spacing of the blocks look better on waddlesplash example. The build information is clearer when made a little bigger and it properly separates Build Info, Check for Updates, Disclaimers and links blocks. I don't know if my intervention has it's place here or if it should be discussed elsewhere thought, but I think if we want to rewrite this dialog we might as well make sure it looks right. |
|
Here's the current version of this PR in Windows 7.
|
|
@JosJuice we eventually fully reverted from that as the implementation was simply not possible to work on every OS combination. |
|
...which is why I didn't ask for it (yet). Was going to poke waddle on IRC before putting it here, but kinda forgot about that :S |
|
I know it's possible to make text in a dialog selectable because I did it in mGBA's about dialog. |
|
I think the window could use less space beneath the copyright line. Also the spacing doesn't look properly centred in @JosJuice's image. Is the copyright symbol being ignored for formatting in Windows for some reason? |
Offline WIP on my end removes it, yeah.
I was copying WX. Looks like it was just a focus ring. Removing.
It's doable. Will do. |
No, looks like I messed up the spacing hints on the last round of changes. |
waddlesplash
force-pushed
the
dolphin-qt
branch
from
40098b5
to
4f0962b
Compare
| @@ -1,4 +1,4 @@ | |||
| // Copyright 2014 Dolphin Emulator Project | |||
| // Copyright 2015 Dolphin Emulator Project | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
@everyone: All comments addressed. Here's what it looks like now: |
waddlesplash
force-pushed
the
dolphin-qt
branch
2 times, most recently
from
add0493
to
e6e7f77
Compare
|
@JosJuice: fixed. |
|
Logo might need a speck more padding, but otherwise LGTM. |
|
Looks nice here. |
|
LGTM, might revise the WX splash to put the bottom sentences together as it looks nicer. |
|
I'm not really a fan of how thick the font is for the title in Windows and I also think there could still be a bit more padding around the logo but otherwise LGTM. |
|
I agree with Pringo, some more padding around the logo would be nice. I like how the WX version is padded, and if you see about dialogs in firefox and VLC they are done in a similar style with a lot of padding around the logo. It gives the logo a great presence in the dialog and a very pleasing composition overall. Let me see if I can show you what I'm seeing... See how consistent the padding is here? Also the Dolphin isn't filling the entire box, and the distance from the logo's tip to the edge of the box, and the distance from the edge of the box to the text/edge of the frame, are all about the same. Composition is all about the arrangement and alignment of details like this within the frame! And how even and nice everything is in the WX version really helps the logo feel like it's cozy in that space. In the Qt version, the logo almost completely fills the box, which is unfortunate. And the padding around the box is very inconsistent, with the left having much less than the other sides. All combined, even though it is the box is a perfect square, it doesn't look like one, it looks taller than it is wide. It's just an illusion of course, but it results in a kind of claustrophobic feeling to the logo, like it's not big enough for the space it's in, like it was smushed into place. Also, the whole window is narrow on the right side as well, closing in very tightly on the "own." to the right. It just needs to be wider, imo. It's issues like this that I think are why it isn't as good compositionally. And like Pringo, I don't like the bold style for the Dolphin text, at least how it appears on Windows. It looks fine in KDE of course, but you know, operating systems and fonts are weird! But the spacing of the text itself overall however is much better! Oh, I'm curious, why did you remove the spacing between "Dolphin is a free and open source GameCube and Wii emulator" and "This software should not be used to play games you do not legally own"? They were separated before because they are separate thoughts, but in comparison to the branch/revision/compiled section one could consider them as "grouped" in a similar way. I'm not super attached to it, but it kind of bothers me... With them so close is that it theoretically connects the emulator with piracy; the separation in the WX version kind of makes it clear that the emulator and "do not do piracy" are separate concepts. In a very very minor note, I still prefer the slight additional horizontal spacing between License | Authors | Support that is in the WX version. That's an extreme nitpick though... @NewLunarFire I don't really care about the text size. :P And my point had nothing to do with that! I'm more worried about the composition and grouping of the items, personally. The bigger text is fine with me, since the grouping of lines takes care of any comprehension issues. |
|
@delroth Can't you somehow blacklist changes to DolphinQt/DolphinWX as not ever impacting graphical rendering? The bot is kinda annoying (and it's wasting time/money...) |
waddlesplash
force-pushed
the
dolphin-qt
branch
from
e6e7f77
to
0c16719
Compare
|
@zopieux done. @MaJoRoesch et al, here's what it looks like now (Qt on top, WX on bottom): |
|
FifoCI detected that this change impacts graphical rendering. Here are the behavior differences detected by the system:
automated-fifoci-reporter |
|
Much better! I approve. Can we get a pic of this on windows? Edit: Whoops! That was windows! |
DolphinQt: Rewrite 'About' dialog to match the new WX one.
Current WX one:
New Qt one:
