DQt2: About Dialog

[rukai]

Comparison between wx bottom and Qt top.

The Lioncash new and improved edition.

[delroth]

What's up with the links looking terrible?

[rukai]

-_- I mixed up the screenshots. wx is bottom and Qt is top.

---

Comments from the review on Reviewable.io

[lioncash]

Review status: 0 of 7 files reviewed at latest revision, 7 unresolved discussions.

---

a discussion (no related file):
The font size for the Dolphin title likely shouldn't that thick/bolded.

---

Source/Core/DolphinQt2/AboutDialog.cpp, line 31 [r1] (raw file):
I don't think adding an interface descriptor is necessary.

---

Source/Core/DolphinQt2/AboutDialog.cpp, line 40 [r1] (raw file):
Should probably resolve this TODO.

---

Source/Core/DolphinQt2/AboutDialog.cpp, line 56 [r1] (raw file):
main_layout

---

Source/Core/DolphinQt2/AboutDialog.cpp, line 68 [r1] (raw file):
missing newline

---

Source/Core/DolphinQt2/AboutDialog.h, line 14 [r1] (raw file):
missing newline

---

Source/Core/DolphinQt2/MenuBar.cpp, line 44 [r1] (raw file):

connect(documentation, &QAction::triggered, this, [=]() {    
    QDesktopServices::openUrl(QUrl(QStringLiteral("https://dolphin-emu.org/docs/guides")));
});

---

Comments from the review on Reviewable.io

[lioncash]

Review status: 0 of 7 files reviewed at latest revision, 4 unresolved discussions.

---

Source/Core/DolphinQt2/AboutDialog.cpp, line 1 [r2] (raw file):
2016

---

Source/Core/DolphinQt2/AboutDialog.cpp, line 9 [r2] (raw file):
DolphinQt/AboutDialog.h

---

Source/Core/DolphinQt2/AboutDialog.cpp, line 10 [r2] (raw file):
DolphinQt/Resources.h

---

Source/Core/DolphinQt2/AboutDialog.h, line 1 [r2] (raw file):
2016

---

Comments from the review on Reviewable.io

[JosJuice]

Is information like the revision hash selectable and copyable, like in the old DolphinQt (PR #2833)?

[rukai]

Yes it is.

---

Review status: 0 of 7 files reviewed at latest revision, all discussions resolved.

---

Comments from the review on Reviewable.io