[AArch64] Optimize cases when an FPR is only used for non-paired ops. #2837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| void BindToRegister(u32 preg, bool do_load, bool only_lower = true); | ||
|
|
||
| // Returns if the register is only the lower 64bit register | ||
| bool IsLower(u32 preg) { return m_guest_registers[preg].GetType() == REG_LOWER_PAIR; } |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Sonicadvance1
force-pushed
the
aarch64_faster_nonpaired
branch
from
4c49b23
to
68f9c36
Compare
| @@ -261,7 +262,8 @@ void Arm64FPRCache::Flush(FlushMode mode, PPCAnalyst::CodeOp* op) | |||
| { | |||
| for (int i = 0; i < 32; ++i) | |||
| { | |||
| if (m_guest_registers[i].GetType() == REG_REG) | |||
| if (m_guest_registers[i].GetType() == REG_REG || | |||
| m_guest_registers[i].GetType() == REG_LOWER_PAIR) | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
Nice work. I'm thinking about adding another state: PS0 and PS1 are mirrored within a single reg, as f32. |
Sonicadvance1
force-pushed
the
aarch64_faster_nonpaired
branch
from
68f9c36
to
7ce4c31
Compare
degasus
added a commit
that referenced
this pull request
Aug 21, 2015
[AArch64] Optimize cases when an FPR is only used for non-paired ops.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.