Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

General: Toss out PRI macro usage #2961

Merged
merged 1 commit into from Sep 6, 2015
Merged

General: Toss out PRI macro usage #2961

merged 1 commit into from Sep 6, 2015

Conversation

lioncash
Copy link
Member

@lioncash lioncash commented Sep 5, 2015

Now that VS supports more printf specifiers, these aren't necessary

@lioncash
General: Toss out PRI macro usage
8fdb013 
Now that VS supports more printf specifiers, these aren't necessary
@phire
Copy link
Member

phire commented Sep 6, 2015

LGTM

phire added a commit that referenced this pull request Sep 6, 2015
@phire
Merge pull request #2961 from lioncash/printf
be4caa3 
General: Toss out PRI macro usage
@phire phire merged commit be4caa3 into dolphin-emu:master Sep 6, 2015
@lioncash lioncash deleted the printf branch September 6, 2015 16:01
@CarlKenner
Copy link
Contributor

Do you have a source that says these are supported? The documentation says they aren't.
https://msdn.microsoft.com/en-us/library/tcxf1dw6(v=vs.140).aspx

@delroth
Copy link
Member

delroth commented Sep 6, 2015

The documentation says the opposite: it is supported.

@lioncash lioncash mentioned this pull request Sep 8, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
4 participants
@lioncash @phire @CarlKenner @delroth