Partially revert "General: Toss out PRI macro usage" #3003
Conversation
|
This is all windows fault. LGTM |
|
LGTM (but needs to be rebased). |
|
@lioncash I'd prefer if you didn't revert the %z changes. |
lioncash
force-pushed
the
revert-2961-printf
branch
2 times, most recently
from
7b90e82
to
29157aa
Compare
lioncash
changed the title
lioncash
force-pushed
the
revert-2961-printf
branch
from
29157aa
to
1942494
Compare
lioncash
force-pushed
the
revert-2961-printf
branch
from
1942494
to
19459e8
Compare
| @@ -952,7 +950,7 @@ IPCCommandResult CWII_IPC_HLE_Device_es::IOCtlV(u32 _CommandAddress) | |||
| if (!bSuccess) | |||
| { | |||
| PanicAlertT("IOCTL_ES_LAUNCH: Game tried to reload a title that is not available in your NAND dump\n" | |||
| "TitleID %016llx.\n Dolphin will likely hang now.", TitleID); | |||
| "TitleID %016" PRIx64".\n Dolphin will likely hang now.", TitleID); | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Partially revert "General: Toss out PRI macro usage"
|
"The hh, j, z, and t length prefixes are not supported." - Visual Studio 2015 documentation. |
|
Why did you revert this @lioncash ? The documentation is wrong here - it IS supported (i've checked). |
|
OK, I was responding to the context of Carl's comment, but his comment doesn't seem to have anything to do with this actual commit... |
|
@CarlKenner z, etc, are in fact supported, otherwise VS 2015 would not suggest them as an amendment for formatting issues e.g. from a project I've been working on |
Reverts #2961 because Linux and Windows can never just use the same formatting specifiers.