Added X-Fi check and convert surround FLOAT to SHORT when it is detected #3024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -146,18 +146,39 @@ void OpenALStream::SoundLoop() | |||
| memset(uiBuffers, 0, numBuffers * sizeof(ALuint)); | |||
| uiSource = 0; | |||
|
|
|||
| // Checks if a X-Fi is being used. If it is, disable FLOAT32 support. | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Fixed braces, first try fixing mac compilation and removed useless NULL comparison.
LAGonauta
force-pushed
the
x-fi-audio-fix
branch
from
2fbe909
to
b98b55c
Compare
|
The driver does what? LGTM |
Sonicadvance1
added a commit
that referenced
this pull request
Sep 12, 2015
Added X-Fi check and convert surround FLOAT to SHORT when it is detected
|
The X-Fi doesn't support floating point buffers, but the driver reports that the X-Fi has support for them. Sorry, I am not a native speaker and have some problems expressing myself. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up from https://bugs.dolphin-emu.org/issues/8711
The OpenAL backend wasn't working on hardware based OpenAL cards (basically only the X-Fi), stereo mode generated buffer queue errors and never played anything, and surround mode was very loud with lots of clipping.
This happens because the X-Fi doesn't support float point operation, only fixed point (even though the drivers reports that it supports).
I added a check to detect a X-Fi, and when it does it converts float to short.
Stereo is perfect now (I used the code that was already there), but for some reason on surround there is some clipping (and this clipping happens even if I force short mode with OpenAL Soft).
I couldn't find why this happens, sadly, but now it is usable.