Port Time Stretching and ProLogic II decoding to all audio backend -- From Ishiiruka #3053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phire:
I pulled this patch out of Tino's custom Ishiiruka-Dolphin build.
Previosly Dolphin only supported these features on the OpenAL backend.
I'm assigning attribution of this patch to Tino, as he did 99% of
the work, I just extracted it and did a few formatting changes.
-- Scott Mansell <phiren@gmail.com>
| //advance indexR with sample position | ||
| //remember fractional offset | ||
| static const float _coeffs[] = | ||
| { -0.5f, 1.0f, -0.5f, 0.0f, |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
phire
force-pushed
the
ishiiruka_timestreching
branch
from
1b3bb21
to
32d2291
Compare
phire
force-pushed
the
ishiiruka_timestreching
branch
from
32d2291
to
6818193
Compare
Backends other than OpenAL use it now.
phire
force-pushed
the
ishiiruka_timestreching
branch
from
6818193
to
0f45f3e
Compare
|
FifoCI appears to be broken due to the null audio backend being broken. Not sure about the pr-win-dbg-x64 failure. The previous 4 (almost identical) builds worked fine and the error message is weird. |
|
FifoCI detected that this change impacts graphical rendering. Here are the behavior differences detected by the system:
automated-fifoci-reporter |
|
This dolphin bot/FifoCI keeps on spamming my email. I've gotten around 13 |
|
@Starsam80 All I can think is to unsubscribe from the issue and just check in manually here. FifoCI is...interesting. |
|
Does not seem to work on Linux. 48 fps on Windows in Four Swords Adventures sounds ridiculously good, but on Linux it is a choppy mess. Using the same settings (30 latency for the sake of testing) except for audio backend. I tried alsa and pulse on Linux. |
| ERROR_LOG(AUDIO, "Could not start backend %s, using %s instead", | ||
| backend.c_str(), BACKEND_NULLSOUND); | ||
| delete g_sound_stream; | ||
| g_sound_stream = new NullSound(); |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
Closing for now. Looks like it might be easier to just re-write the whole thing rather than reviewing. |
|
I hope you do make a working version of this, Prologic and time-stretching for Xaudio is something I've wanted for a while. :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I pulled this patch out of Tino's custom Ishiiruka-Dolphin build.
Previously Dolphin only supported these features on the OpenAL backend.
Note: ProLogic II decoding is only enabled on the backends that have support for outputting more than 2 channels of audio, currently OpenAL (excluding Mac) and XAudio.
This also fixes Issue 7955. Yes, I extracted this patch just so that issue could be closed.
I'm assigning attribution of this patch to @tino, as he did 99% of the work, I just extracted it and did a few formatting changes.
TODO: