DolphinWX: decompress discs to calculate MD5 hash #3047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The idea and implementation are good in general, but I think the blob implementations for CISO and WBFS unfortunately make GetDataSize() return the file size instead of the data size. That should be fixed before this is merged. |
Tilka
force-pushed
the
decompress_for_md5
branch
from
b79e0c6
to
559bc59
Compare
| @@ -19,7 +19,7 @@ class WbfsFileReader : public IBlobReader | |||
| public: | |||
| static WbfsFileReader* Create(const std::string& filename); | |||
|
|
|||
| u64 GetDataSize() const override { return m_size; } | |||
| u64 GetDataSize() const override; | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Tilka
force-pushed
the
decompress_for_md5
branch
from
559bc59
to
d6bd57a
Compare
|
LGTM. |
| @@ -44,7 +44,7 @@ CISOFileReader* CISOFileReader::Create(const std::string& filename) | |||
|
|
|||
| u64 CISOFileReader::GetDataSize() const | |||
| { | |||
| return GetRawSize(); | |||
| return CISO_MAP_SIZE * m_block_size; | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
btw, this needs a rebase. |
Instead of rounding down, round up.
This is a best-effort approach, since the CISO format does not save the original file size.
Tilka
force-pushed
the
decompress_for_md5
branch
from
d6bd57a
to
00aefa5
Compare
|
LGTM |
Tilka
added a commit
that referenced
this pull request
Oct 12, 2015
DolphinWX: decompress discs to calculate MD5 hash
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main use case of calculating the MD5 hash is to compare it to known-good values.