Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clean up bounds checking for SIDEVICE_ENUM #4101

Merged
merged 1 commit into from Aug 8, 2016
Merged

clean up bounds checking for SIDEVICE_ENUM #4101

merged 1 commit into from Aug 8, 2016

Conversation

meffij
Copy link
Contributor

@meffij meffij commented Aug 7, 2016 •
edited by delroth

This change is Reviewable

@shuffle2
Copy link
Contributor

shuffle2 commented Aug 8, 2016

should not need to cast the enum values to int...

@degasus
Copy link
Member

degasus commented Aug 8, 2016

Without the casts, it LGTM

@meffij
Copy link
Contributor Author

meffij commented Aug 8, 2016

Do you think we should switch the enum to uint to save the lower bounds check as well? Someone was saying that'd be better.

@lioncash
Copy link
Member

lioncash commented Aug 8, 2016

Please squash your changes (see here for more on that, if you don't know how).

@phire
Copy link
Member

phire commented Aug 8, 2016

:lgtm:

Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

@phire phire merged commit d56ae50 into dolphin-emu:master Aug 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
5 participants
@meffij @shuffle2 @degasus @lioncash @phire