PixelShaderGen: Always divide the texture coordinates by q. #4197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some games will set q to a different value than 1.0 through texture matrix manipulations. It seems the console will still do the division in that case.
|
Confirmed to be the correct behavior with a hardware test |
CrossVR
changed the title
|
Reviewed 1 of 1 files at r1. Comments from Reviewable |
|
Melee confirmed to be like this PR. Slight error no one noticed for years. |
|
FifoCI detected that this change impacts graphical rendering. Here are the behavior differences detected by the system:
automated-fifoci-reporter |
|
Very unexpected result, but if it's validated by a hw test, LGTM |
|
Does anyone have the escape from bug island to test whether the map is properly aligned? |
|
I don't, but I will try to keep an eye out for it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some games will set q to a different value than 1.0 through texture postmatrix manipulations. It seems the console will still do the division in that case.
Fixes the map being up-side down in Fishing Resort.
This change is