Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove '\n' from OSD messages; they would be converted to '?' #4294

Merged
merged 1 commit into from Oct 4, 2016
Merged

Remove '\n' from OSD messages; they would be converted to '?' #4294

merged 1 commit into from Oct 4, 2016

Conversation

shuffle2
Copy link
Contributor

@shuffle2 shuffle2 commented Oct 4, 2016 •
edited by delroth

Recent commit replaces !isprint chars with '?', so the output started looking a bit funky...

This change is Reviewable

@lioncash lioncash merged commit 9ecd250 into dolphin-emu:master Oct 4, 2016
@degasus
Copy link
Member

degasus commented Oct 5, 2016

\n did work fine on the OGL backend. By the way, GPU statistics aren't working any more. I'll bisect it later...

@shuffle2
Copy link
Contributor Author

shuffle2 commented Oct 5, 2016

@degasus if it's too annoying, just revert this commit and the one which caused this...it didn't seem like a very important "cleanup"... shrug

@shuffle2 shuffle2 deleted the remove-osd-newlines branch June 2, 2017 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
3 participants
@shuffle2 @degasus @lioncash