Jit64: Make register caches not rely on the global jit variable #4535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
Keeps them separated from one another and makes it less annoying to find member functions (which were previously spread out all over the place).
…icable Any future changes to these register cache functions won't require everything that includes the register cache header to also be recompiled.
This was kind of a pointless function, considering the parameter wasn't used at all, so the other Flush() function could have been just directly used instead.
|
Rebased on top of master. Also made a slight change to the last commit. Previously it would take the |
iwubcode
reviewed
Dec 28, 2016
| m_emitter->MOVAPD(new_loc, m_regs[preg].location); | ||
| } | ||
|
|
||
| const X64Reg* FPURegCache::GetAllocationOrder(size_t* count) |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also includes preliminary cleanup that leads up to replacing the global usages
Each change should be relatively self-contained.