IOS STM: Get rid of forward declarations in the cpp file #4786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Forward declaring functions from a completely different header inside a cpp file can lead to linker errors. Forward declaring also doesn't really provide any benefit within cpp files unless it's to bring an internally linked function within the same file into scope.
iwubcode
approved these changes
Jan 30, 2017
leoetlino
approved these changes
Jan 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forward declaring functions from a completely different header inside a cpp file can lead to linker errors if either of those functions have changes to their parameter set. Forward declaring also doesn't really provide any benefit within cpp files unless it's to bring an internally linked function within said cpp file into scope.