InputCommon: Move ControllerEmu to its own directory #4789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iwubcode
approved these changes
Jan 30, 2017
|
I started doing a bit of this in #4502: Extract ControlReference from ControllerInterface EDIT: jk, that's something different |
|
https://github.com/dolphin-emu/dolphin/blob/master/Contributing.md#general |
Orphis
approved these changes
Jan 31, 2017
ControllerEmu is a massive class with a lot of nested public classes. The only reason these are nested is because the outer class acts as a namespace. There's no reason to keep these classes nested just for that. Keeping these classes nested makes it impossible to forward declare them, which leads to quite a few includes in other headers, making compilation take longer. This moves the source files to their own directory so classes can be separated as necessary to their own source files, and be namespaced under the ControllerEmu namespace.
Tabs -> Spaces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ControllerEmu is a massive class with a lot of nested public classes.
The only reason these are nested is because the outer class acts as a namespace. There's no reason to keep these classes nested just for that. Keeping these classes nested makes it impossible to forward declare them, which leads to quite a few includes in other headers, making compilation take longer (especially when changes are made to ControllerEmu).
This moves the source files to their own directory so inner classes can be separated as needed to their own source files, and be namespaced under the ControllerEmu namespace.
This change just gets the main boilerplate stuff out of the way first (settings up the VS filters, etc). Follow ups to this will move inner classes to their own source files.