Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add headless support on macOS #5276

Merged
merged 3 commits into from Jun 6, 2017
Merged

Conversation

ligfx
Copy link
Contributor

@ligfx ligfx commented Apr 16, 2017

No description provided.

@@ -49,15 +33,34 @@
return false;
}

if (cocoaWin == nil)
if (window_handle)

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

@stenzek
Copy link
Contributor

stenzek commented Apr 16, 2017

LGTM

@@ -5,31 +5,54 @@
#include "Common/GL/GLInterface/AGL.h"
#include "Common/Logging/Log.h"

void cInterfaceAGL::Swap()
static bool DimensionsWereUpdated(NSView* view, u32* width, u32* height)

This comment was marked as off-topic.

@Orphis
Copy link
Member

Orphis commented Apr 16, 2017

Good, I'm going to continue thinking of features I want, not say a word and expect @ligfx to implement them for me. Thanks!

@ligfx
Copy link
Contributor Author

ligfx commented Apr 16, 2017

@Orphis I got you fam 👍

@ligfx
Copy link
Contributor Author

ligfx commented May 4, 2017

Ping!

Also @Sonicadvance1 I know I talked with you on IRC, but there is anything else about this that I need to change?

@shuffle2
Copy link
Contributor

shuffle2 commented Jun 6, 2017

is there something pending here?

@ligfx
Copy link
Contributor Author

ligfx commented Jun 6, 2017

@shuffle2 Not that I know of.

@shuffle2 shuffle2 merged commit 192fec5 into dolphin-emu:master Jun 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
5 participants