AudioCommon: Move DPL2 decoding into Mixer #5311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lioncash
reviewed
Apr 24, 2017
| class AudioStretcher | ||
| { | ||
| public: | ||
| AudioStretcher(unsigned int sample_rate); |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
| // Licensed under GPLv2+ | ||
| // Refer to the license.txt file included. | ||
|
|
||
| #include <cmath> |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
Ping! Anything holding this back? @MerryMage if you have the time, would you mind taking a look? |
|
Needs a rebase. |
|
Logic LGTM |
|
Rebased! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pretty straightforward, though testing is a little janky on macOS (OpenAL doesn't support multichannel, so I hacked up CoreAudioStream on my local copy).
Also extracts out @MerryMage's time-stretching logic into an AudioStretcher class and splits it into two functions, to make clear that you can use the same buffer for input and output. Not really sure about this, but it seemed silly to add another intermediate buffer when the existing one works fine.