CMake: clean up HIDAPI build #5318
Conversation
ligfx
force-pushed
the
cmakehidapi
branch
2 times, most recently
from
c473008
to
6155fc6
Compare
Externals/hidapi/CMakeLists.txt
Outdated
| @@ -0,0 +1,24 @@ | |||
| project(hidapi) | |||
|
|
|||
| set(SRCS) | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Externals/hidapi/CMakeLists.txt
Outdated
| target_link_libraries(hidapi PRIVATE ${LIBS}) | ||
| target_include_directories(hidapi PUBLIC hidapi) | ||
|
|
||
| add_library(Hidapi::Hidapi ALIAS hidapi) |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Externals/hidapi/CMakeLists.txt
Outdated
| target_sources(hidapi PRIVATE windows/hid.c) | ||
| else() | ||
| find_package(Libudev) | ||
| if(${CMAKE_SYSTEM_NAME} STREQUAL "Linux" AND LIBUDEV_FOUND) |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Externals/hidapi/CMakeLists.txt
Outdated
| @@ -0,0 +1,20 @@ | |||
| project(hidapi) | |||
|
|
|||
| add_library(hidapi hidapi/hidapi.h) | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
Can we merge this? |
|
Ping! |
|
Sorry for the delay, had to call in the lads to do some line repair to respond with this pong |
|
fwiw, once files are in git, removing them doesn't save much :P (re: "Remove HIDAPI Autotools build system and unused files") imo it's more annoying to wind up with some derivative of the external. |
|
This breaks the build on my cluster :( |
No description provided.