Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qt: Add Interface Pane to Settings #5378

Merged
merged 1 commit into from
May 11, 2017

Conversation

Ryanel
Copy link
Contributor

@Ryanel Ryanel commented May 6, 2017

Adds the interface pane to Qt Settings.
Nothing fancy, particularly.

(Note that theme is not honored by the Qt Client yet, but the setting still can be modified and viewed in the WX Client)

image

@ghost
Copy link

ghost commented May 6, 2017

That's just the WIN10 Theme right? Hopefully it will look proper on Win7.

@Ryanel
Copy link
Contributor Author

Ryanel commented May 6, 2017

@ZexaronS what? What looks wrong?

And yeah, I'm building this on Windows 10

@ghost
Copy link

ghost commented May 6, 2017

@Ryanel
As long as OS-specific window GUI theme is retained and the program is compatible with OSs down to Win7, there's nothing wrong. I simply don't like the Win10 GUI and don't want it too look like that on my PC.

If I would use Win10 in future, I would first tweak or even hack it to get the Win7 GUI back. I will not adapt to corporate silicon-valley opinions and cultures, views of which I'm quite honestly hostile to, to me they might as well be aliens from outter space, I want to keep using the GUI themes I like for the rest of my life, I do not subscribe to the liknesesses of corporate marketing teams and trends dictating what kind of theme I should use for new products.

@JosJuice
Copy link
Member

JosJuice commented May 6, 2017

@ZexaronS Pull request comments are not the place for posting irrelevant opinions. Please stay on topic.

And yes, of course Dolphin is not going to use a Windows 10 appearance when running on Windows 7...

Q_OBJECT
public:
explicit InterfacePane(QWidget* parent = nullptr);
void LoadConfig();

This comment was marked as off-topic.

void LoadConfig();

private slots:
void SaveConfig();

This comment was marked as off-topic.

@Ryanel Ryanel force-pushed the qt-settings-interface branch 2 times, most recently from 239013b to 076e562 Compare May 7, 2017 19:51
Adds the interface pane to Qt Settings. Very basic, just some UI
customization options.
Copy link
Contributor

@Helios747 Helios747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Helios747 Helios747 merged commit 33980d8 into dolphin-emu:master May 11, 2017
@leoetlino leoetlino modified the milestone: Qt Sep 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
5 participants