Qt: Fix games crashing on start #5471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this a fix for https://bugs.dolphin-emu.org/issues/10300 ? |
|
Yes. But I thought that Qt Bugs didn't belong in the bug tracker? |
|
If it's in the https://github.com/dolphin-emu/dolphin repo, it belongs on the bug tracker. At least that's what I've been going by, and I think it makes sense. Did anyone say something else? |
|
@JosJuice Well...the UI itself says so: But I guess that's up for discussion (although I'd prefer to discuss this in IRC instead of adding more nonsensical comments to this PR) |
Helios747
approved these changes
May 23, 2017
lioncash
reviewed
May 23, 2017
| if (g_controller_interface.IsInit()) | ||
| return; | ||
|
|
||
| g_controller_interface.Initialize(reinterpret_cast<void*>(reinterpret_cast<void*>(winId()))); |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
spycrab
force-pushed
the
qt_crash_gamestart
branch
from
d87981b
to
d65006b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a regression caused by the button mapping windows