Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed latency setting and cleaned-up OpenAL backend #5631

Merged
merged 5 commits into from
Jun 27, 2017
Merged

Fixed latency setting and cleaned-up OpenAL backend #5631

merged 5 commits into from
Jun 27, 2017

Commits on Jun 27, 2017

  1. Changed OpenAL latency setting to really reflect how much time it is. 

    Before these changes each value of latency were actually 5ms, with a
minimum latency of ~10 ms. If it was set to 4 ms on the UI, the actual
latency was 10 + 5 * 4 = 30 ms.
Now 30 ms on the UI means 30 ms on the backend.
    @LAGonauta
    LAGonauta committed Jun 27, 2017
    Configuration menu
    Copy the full SHA
    8fd1af6 View commit details
    Browse the repository at this point in the history

  2. Renamed some variables to the current coding standard and some to better 

    fit what they really are.
    @LAGonauta
    LAGonauta committed Jun 27, 2017
    Configuration menu
    Copy the full SHA
    d9d51fe View commit details
    Browse the repository at this point in the history

  3. Swapped out the sound_sync_event.Wait() call by a simple std::sleep_for. 

    It seems to make no difference besides allowing lower latencies and more
stability on hardware OpenAL cards. Maybe the Wait() call waits for too
long, causing buffers underruns.
    @LAGonauta
    LAGonauta committed Jun 27, 2017
    Configuration menu
    Copy the full SHA
    75af792 View commit details
    Browse the repository at this point in the history

  4. Removed redundant conversion to float when playing back stereo.

    @LAGonauta
    LAGonauta committed Jun 27, 2017
    Configuration menu
    Copy the full SHA
    9eb209c View commit details
    Browse the repository at this point in the history

  5. Swapped C-style arrays to std::array 

    Also changed C-Style casts to static_cast
    @LAGonauta
    LAGonauta committed Jun 27, 2017
    Configuration menu
    Copy the full SHA
    db7bb3b View commit details
    Browse the repository at this point in the history