D3D: Implement logic op support #6013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are now incorporated into the blend state for all backends.
This decouples the state generation (from the emulated GPU) from the management of internal backend state.
This is required for D3D to support logic op.
stenzek
commented
Sep 3, 2017
| @@ -43,7 +43,8 @@ struct pixel_shader_uid_data | |||
| u32 numColorChans : 2; | |||
| u32 rgba6_format : 1; | |||
| u32 dither : 1; | |||
| u32 pad : 16; | |||
| u32 uint_output : 1; | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
I get the following Warning when trying to boot any game: (occurs twice but then after clicking ok, everything seems to look fine). Regardless, Okami and Opoona seem to be fixed in this PR. |
This brings D3D to parity with OpenGL and Vulkan.
|
@iwubcode Should be fixed now. Interesting that the NV driver doesn't complain about this (uint view on a unorm texture instead of typeless). The validation layer would have caught it if I had left it enabled when testing though.. |
iwubcode
approved these changes
Sep 4, 2017
This was referenced Sep 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires #5337.
This brings D3D to parity with OpenGL and Vulkan, however at the cost of additional shader variants, since D3D doesn't implicitly convert the floating point color to integer first (just reinterprets the bits).
It also requires Direct3D 11.1, and a WDDM 1.2 driver. So, this will only work on Windows 8 and above. Windows 7 will result in visual breakage in games which uses logic ops, but the approximation method used before was significantly incorrect anyway.
Fixes https://bugs.dolphin-emu.org/issues/10513 and probably others.