DolphinWX: Allow short-hand searching in the code window #602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lioncash: This comment grants you the permission to merge this pull request whenever you think it is ready. After addressing the remaining comments, click this link to merge. LGTM @dolphin-emu-bot allowmerge |
|
The reason it was like this is to prevent continuously moving the view while you are typing in an address. |
|
Also, I'm curious if wxw just has a builtin for string -> integer. What if you paste a hex address prefixed by 0x, or similar things? Probably a function to parse all this stuff already exists somewhere. |
|
Updated to use the wx built-ins (this also handles strings with "0x" prefixed to them now) |
|
Should be all good now. |
Lessens the restrictions on the searching in the code view. Now typing out the full 8 digit hex number isn't needed. For example, you don't need to type 000000FF to go to FF, you just literally type FF. Also makes JumpToAddress a boolean function to remain consistent with the DSP code view. This will also change the address search box to have a red background if either an invalid hex number is given, or if it's longer than 8 characters
|
Looks good to me. |
dolphin-emu-bot
added a commit
that referenced
this pull request
Jul 11, 2014
DolphinWX: Allow short-hand searching in the code window
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lessens the restrictions on the searching in the code view.
Now typing out the full 8 digit hex number isn't needed. For example, you don't need to type
000000FFto go to FF, you just literally typeFF.Also makes
JumpToAddressa boolean function to remain consistent with the DSP code view.This will also change the address search box to have a red background if either an invalid hex number is given, or if it's longer than 8 characters. This is similar to how the DSP address box works as well.