Consolidate ec_wii functions into IOSC #6388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BhaaLseN
approved these changes
Feb 19, 2018
It's always 4 bytes long, so let's just make it a u32.
Preliminary commit for merging ec_wii into IOSC.
Equivalent of IOSC_GenerateCertificate + IOSC_GeneratePublicKeySign. This is copied from ec_wii/MakeAPSigAndCert.
|
Got JMC to test this after fixing some bugs I've found during testing -- everything should be fine with a NAND or without. |
lioncash
approved these changes
Feb 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves ec_wii functions to IOSC to have Wii crypto-related code in one place. Having it in IOSC is more logical because it more closely mirrors the original architecture. It also prevents exposing implementation details -- the dump file format, keys, default values, etc. all shouldn't be visible -- and it lets us get rid of a singleton that shouldn't ever have existed considering the crypto code is only used by ES/network and thus it would have been natural to tie state lifetime to IOS (like a Wii).
By removing the singleton, re-opening Dolphin after importing a NAND dump should now be unnecessary.