HW: Fix infinite rumble on emulation pause

[Kekker-git]

This fixes the old issue of rumble not stopping when emulation is paused. It was fixed for the GameCube adapter and LibUSB controllers here, but that fix did not work for XInput or DInput controllers on Windows.

A partner and I tested on two different machines in multiple games and multiple controllers. With XInput controllers, the rumble stopped on emulation pause and resumed where appropriate, and stopped properly on emulation close. Neither me nor my partner were able to test with DInput. I have a DInput controller, but my rumble motors are not recognized by Dolphin on any build that I've tested.

I believe it follows the code style guidelines, but this is the first pull request from my team so if anything is off please let us know.

[lioncash]

This can also likely just be a single commit or two (given 2 are added, and then 2 are just reverting them). It's also a convention to prefix the commits with the general area they're modifying.

e.g.

Core: Fix thing

[Kekker-git]

Yes, I figured the two reverts would seem odd. We're working on this as part of a project, and our professor wanted us to modify the "about" text with our names. I'm not entirely certain how to delete the commits or if I even can, so I just reverted them.

Sorry about the prefix bit; if anyone else is wondering, this is modifying Core/Core and Core/Core/HW.

[lioncash]

You can amend this like so:

1. Run git --reset hard HEAD~2 to get rid of the reversion commits
2. Now we only have 4 left to deal with so run git rebase HEAD~4
3. You should now be in a vim-like CLI interface. Press I (not L, in case they look similar on your browser's font), then remove the two lines that have the first two initial commits. This will drop them entirely.
4. Change the text that says pick next to the "Fix rumble on emulation pause" commit to s (to squash it down into the other commit).
5. Press ESC to exit editing mode and then type :x to save and quit.

Once this runs, type git commit --amend. The same vim-like interface comes up, so press I and you can then edit the commit message. Exiting it is done the same way as before.

Then push the commits with git push -f origin master.

[Kekker-git]

It should be fixed. I squashed it to one commit, removed the reverts, and made a static ResetRumble() function that is called whenever the rumble reset is needed.

[leoetlino]

Code looks fine to me now, but please rebase your branch and squash the commits.

[Kekker-git]

Sorry it took me a while. I had squashed the commits, but asked my partner to move the ResetRumble() function and he didn't squash his commits. The commit has been rebased and squashed to one commit, with ResetRumble() above the Stop() function where it was first called.