Core: Kill off a few Host interface functions. #740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Probably need to update MainNoGUI and StubHost as well to remove this function. |
|
Wait a sec on merging this, might be able to kill off a third one here. EDIT: This is currently ongoing. This will be OK to merge once all the GL interfaces have host calls killed off. |
lioncash
changed the title
|
@dolphin-emu-bot rebuild |
|
Tested on Ubuntu 14.04: still builds & runs. |
|
Alright, thanks.
|
|
Looks good. |
|
OK, LGTM. |
| @@ -81,7 +73,7 @@ void *cXInterface::CreateWindow(void) | |||
|
|
|||
| // Create the window | |||
| GLWin.win = XCreateWindow(GLWin.evdpy, GLWin.parent, | |||
| GLWin.x, GLWin.y, GLWin.width, GLWin.height, 0, | |||
| 0, 0, 1, 1, 0, | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Uses wxWidgets event propagation to the parent window which then appropriately handles the breakpoint list updating.
This was actually never used as far as I can tell. There was no wx event handling done whatsoever for the global ID, So this is basically a dead function.
Just use the Windows API to accomplish the same thing (this is what is done in Update()). This makes the backing window handle the correct data-type for Windows for easier use in function calls.
Just uses platform-specific ways to do the same thing.
Also remove x, y, width and height from the GLInterface, since it's only used in GLX, which no longer uses them
lioncash
added a commit
that referenced
this pull request
Aug 9, 2014
Core: Kill off a few Host interface functions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kills off some of the Host interface functions. Many of these are a result of not using the event system in wx correctly, or are just used as a quick kludge.