Core: Default initialize a pointer to nullptr in gdsp_do_dma() #748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The if-statement implies that this could fail in the switch statement somehow. If it does fail, then we'd be comparing with an uninitialized pointer.
|
"switch (ctl & 0x3)" -- so I doubt that it will be used uninitialized. But if the compiler warns, it also didn't optimize, so LGTM |
shuffle2
added a commit
that referenced
this pull request
Aug 12, 2014
Core: Default initialize a pointer to nullptr in gdsp_do_dma()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The if-statement implies that this could fail comparison for a case in the switch statement somehow. If it does fail, then we'd be comparing for nullity with an uninitialized pointer.
Even if this isn't possible, Clang still warns about potential uninitialized values.