CommandProcessor: Don't reset gather pipe on write the high distance bit (fixes monster lab) #8039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…not reflect what actually happens on real hardware. On hardware, there's no way for the GPU to signal to reset the WPAR buffer. Instead, the WPAR buffer will be reset automatically upon receiving 32 bytes or when spr[WPAR] is written
iwubcode
force-pushed
the
monster_lab_fix
branch
from
7a4f074
to
c2abf09
Compare
|
with this pr, resident evil zero warning unknown opcode on launch. |
|
It'll probably get fixed with better GPU timings. This behavior has been hardware tested. |
Pwootage
added a commit
to Pwootage/dolphin
that referenced
this pull request
May 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On investigating why Monster Lab would not boot, I noticed some extra commands in the last commit that broke the game. Removing this line allowed game to boot normally.
After discussion, it turns out the current code isn't following the hardware's behavior. On real hardware the gather-pipe or WPAR buffer will only be reset upon receiving 32bytes.
Big thanks to @booto for help explaining the hardware side of it and doing the hardware test that confirms this.
Fixes issue 9249
Fixes issue 10826