Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{Android/ButtonManager, ResourcePack/Manager}: Make file-scope variables/functions internally linked where applicable #8165

Merged
merged 3 commits into from Jun 8, 2019

Conversation

2 participants
@lioncash
Copy link
Member

commented Jun 8, 2019

Resolves -Wmissing-variable-declarations and -Wmissing-declarations warnings.

While we're at it, we can make some of the locals constexpr in Android's case.

lioncash added some commits Jun 8, 2019

Android/ButtonManager: Make local file-scope variables internally lin…
…ked where applicable

Silences a few -Wmissing-variable-declarations warnings.
Android/ButtonManager: Make most file-scope local variables non-alloc…
…ating

We can use std::array and const char* to make these capable of fully
being stored in the read-only segment, and get rid of a few static
constructors (144 of them).
UICommon/ResourcePack/Manager: Make GetPackConfig() internally linked
Silences a -Wmissing-declarations warning.
@stenzek

stenzek approved these changes Jun 8, 2019

Copy link
Contributor

left a comment

LGTM

@stenzek stenzek merged commit b13e00b into dolphin-emu:master Jun 8, 2019

10 checks passed

default Very basic checks passed, handed off to Buildbot.
Details
lint Build succeeded on builder lint
Details
pr-android Build succeeded on builder pr-android
Details
pr-deb-dbg-x64 Build succeeded on builder pr-deb-dbg-x64
Details
pr-deb-x64 Build succeeded on builder pr-deb-x64
Details
pr-freebsd-x64 Build succeeded on builder pr-freebsd-x64
Details
pr-osx-x64 Build succeeded on builder pr-osx-x64
Details
pr-ubu-x64 Build succeeded on builder pr-ubu-x64
Details
pr-win-dbg-x64 Build succeeded on builder pr-win-dbg-x64
Details
pr-win-x64 Build succeeded on builder pr-win-x64
Details

@lioncash lioncash deleted the lioncash:linkage branch Jun 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.