{Android/ButtonManager, ResourcePack/Manager}: Make file-scope variables/functions internally linked where applicable #8165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ked where applicable Silences a few -Wmissing-variable-declarations warnings.
…ating We can use std::array and const char* to make these capable of fully being stored in the read-only segment, and get rid of a few static constructors (144 of them).
Silences a -Wmissing-declarations warning.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves -Wmissing-variable-declarations and -Wmissing-declarations warnings.
While we're at it, we can make some of the locals constexpr in Android's case.