Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VideoCommon/Statistics: Use std::array for projection values #8207

Merged
merged 3 commits into from Jun 29, 2019

Conversation

lioncash
Copy link
Member

Allows us to greatly simplify how these values were being set from the vertex shader manager. Now it's as basic as assigning directly to the members as opposed to setting each member individually.

Makes the members within the interface much nicer to look at, and also
makes copying them over much nicer too.
Now that the floating point members are assigned in bulk, we can remove
their setter macro. While we're at it, we can also remove the setter for
unsigned int, given it's not used.
We can use this to shorten up the initialization code a little bit.

Despite being saved to savestates, this is a non-breaking change.
Copy link
Member

@leoetlino leoetlino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much nicer!

@leoetlino leoetlino merged commit a9099fc into dolphin-emu:master Jun 29, 2019
@lioncash lioncash deleted the macro branch July 3, 2019 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants