Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core: Initialize all JITIL RegInfo members in the initializer list. #836

Merged
merged 2 commits into from Sep 4, 2014
Merged

Core: Initialize all JITIL RegInfo members in the initializer list. #836

merged 2 commits into from Sep 4, 2014

Conversation

lioncash
Copy link
Member

No description provided.

delroth
delroth reviewed Aug 23, 2014
View reviewed changes
Source/Core/Core/PowerPC/Jit64IL/IR_X86.cpp
exitNumber = 0;
RegInfo(JitIL* j, InstLoc f, unsigned insts)
: Jit(j), Build(nullptr), FirstI(f), IInfo(insts), lastUsed(insts)
, regs(), fregs(), numSpills(0), numFSpills(0), exitNumber(0)

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

@lioncash
Copy link
Member Author

@shuffle2 What should we do about this, considering the warning?

@shuffle2
Copy link
Contributor

shuffle2 commented Sep 3, 2014

I assume the warning is meant to warn people about possible perf impact where there was none before. Dolphin is a C++11(+) project so I think we can just disable this warning.
@lioncash Feel free to disable this warning globally in base.props:

<DisableSpecificWarnings>4996;4351</DisableSpecificWarnings>

@lioncash
Copy link
Member Author

lioncash commented Sep 3, 2014

Sure thing. I'll add it to this PR later today.

@lioncash
Copy link
Member Author

lioncash commented Sep 4, 2014

@shuffle2 Should be good now.

shuffle2 added a commit that referenced this pull request Sep 4, 2014
@shuffle2
Merge pull request #836 from lioncash/initlist
46c18aa 
Core: Initialize all JITIL RegInfo members in the initializer list.
@shuffle2 shuffle2 merged commit 46c18aa into dolphin-emu:master Sep 4, 2014
@lioncash lioncash deleted the initlist branch September 4, 2014 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
6 participants
@lioncash @shuffle2 @delroth @BhaaLseN @neobrain @badkarma12