Fixing video for EA games like Fifa 07

[raelgc]

This will remove the glitch (something like jailbars) in EA videos (like the opening "EA Sports, it's in the game" in Fifa 07).

Tested in OpenGL renderer.

Discussion: https://bugs.dolphin-emu.org/issues/7193#note-25

[stenzek]

Not a huge fan of the "hack", but outside of implementing sampling/filtering in the shader (and taking the performance hit) I haven't thought of a better idea..

If this were to go ahead, you'd want to update the ubershader as well.

[AdmiralCurtiss]

I'd also recommend a big comment about why this hack is in and what the 'proper' implementation of it would be.

[raelgc]

@AdmiralCurtiss: It looks like the source of the issue is a rounding error. According the author of the working solution:

The real fix for this is to integerize texture lookups, but wow that is out of my realm of expertise.

[iwubcode]

Has this been tested against other games? I'm just wondering if this breaks anything. What about fifoci?

I know of a number of small graphical (potentially texture related?) game errors, I've always wondered if Dolphin had something wrong somewhere but wasn't sure where to look. I'll have to see if this fixes any of them.

If it is merged, it feels like it should be a togglable hack, kinda like vertex rounding.

[endrift]

Hello, original author of that hack here. There was a reason this never got merged. See also the original PR for this: #3807

[raelgc]

Ok, so, how if I implement like suggested on #3807: a 0.25 rounding that will be tied to a [Core] option that can be enabled for some games (like FPRF)? Something titled "Fix rounding issue in texture lookup"?

[dkacperski97]

So what is the status of this PR? It seems https://bugs.dolphin-emu.org/issues/4570 (mentioned in the original PR) has been fixed, but the changes didn't fix https://bugs.dolphin-emu.org/issues/7193.

[Miksel12]

I think this pr should be closed as #9407 shows that the epsilon value needed depends on which game and which hardware you are running. Making an epsilon hack very hacky.

[endrift]

Honestly I didn't realize this was still open. Oh, but I'm not the one who filed it. It was just someone taking a test I'd done and saying it was appropriate to PR it...no wonder I hadn't already closed it.

[JMC47]

Everyone is recommending this be closed. This is still a mystery to this day.