Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing video for EA games like Fifa 07 #8409

Open
wants to merge 1 commit into
base: master
from

Conversation

@raelgc
Copy link
Contributor

raelgc commented Oct 17, 2019

This will remove the glitch (something like jailbars) in EA videos (like the opening "EA Sports, it's in the game" in Fifa 07).

Tested in OpenGL renderer.

Discussion: https://bugs.dolphin-emu.org/issues/7193#note-25

@stenzek

This comment has been minimized.

Copy link
Contributor

stenzek commented Oct 17, 2019

Not a huge fan of the "hack", but outside of implementing sampling/filtering in the shader (and taking the performance hit) I haven't thought of a better idea..

If this were to go ahead, you'd want to update the ubershader as well.

@AdmiralCurtiss

This comment has been minimized.

Copy link
Contributor

AdmiralCurtiss commented Oct 17, 2019

I'd also recommend a big comment about why this hack is in and what the 'proper' implementation of it would be.

@raelgc

This comment has been minimized.

Copy link
Contributor Author

raelgc commented Oct 17, 2019

@AdmiralCurtiss: It looks like the source of the issue is a rounding error. According the author of the working solution:

The real fix for this is to integerize texture lookups, but wow that is out of my realm of expertise.

@iwubcode

This comment has been minimized.

Copy link
Contributor

iwubcode commented Oct 18, 2019

Has this been tested against other games? I'm just wondering if this breaks anything. What about fifoci?

I know of a number of small graphical (potentially texture related?) game errors, I've always wondered if Dolphin had something wrong somewhere but wasn't sure where to look. I'll have to see if this fixes any of them.

If it is merged, it feels like it should be a togglable hack, kinda like vertex rounding.

@endrift

This comment has been minimized.

Copy link
Contributor

endrift commented Oct 18, 2019

Hello, original author of that hack here. There was a reason this never got merged. See also the original PR for this: #3807

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
You can’t perform that action at this time.