Common: Kill off duplicate log warning definitions #851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lioncash
force-pushed
the
logg
branch
2 times, most recently
from
5311e95
to
724a163
Compare
|
Something funky going on with android build...please fix that (and rebasing would be nice). |
Also embed the log checks rather than using macros
Changed them all from debug asserts to regular asserts, since they shouldn't only be run at debug time.
shuffle2
added a commit
that referenced
this pull request
Sep 6, 2014
Common: Kill off duplicate log warning definitions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also embed the log checks rather than using macros