macOS: Untranslocate the app bundle's path for the updater #8915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lioncash
reviewed
Jun 30, 2020
leoetlino
requested changes
Oct 21, 2020
OatmealDome
force-pushed
the
updater-temp-dir
branch
from
6dc477a
to
17959ce
Compare
|
Addressed comments. |
leoetlino
reviewed
Nov 2, 2020
OatmealDome
force-pushed
the
updater-temp-dir
branch
from
17959ce
to
833d5a3
Compare
|
Finally got around to rebasing. Should fix at least one of the issues plaguing the macOS updater right now (app not launching if downloaded from the Internet). Tested on an Intel MacBook Pro, but should still be OK on an M1. |
leoetlino
approved these changes
Jul 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting in macOS Sierra, if an app is downloaded from the Internet, the system may "translocate" an app's bundle to a read-only container elsewhere on the filesystem and execute it from there. This is done to protect against a trusted application's resources from being hijacked to load untrusted code. More information is available here (with many thanks to Patrick Wardle).
Unfortunately, this has the side-effect of breaking the updater, as it'll attempt to find the updater app bundle from the read-only container. So,
GetBundleDirectory()has been changed to "untranslocate" the app bundle's path if necessary. The APIs used to do this were briefly public in Xcode 8 beta 1, but they were made private in a later beta. There is no other way to untranslocate a path (as far as I know). The headers are still open source, however.Also, this PR includes a fix for https://bugs.dolphin-emu.org/issues/11784. The updater's working directory is now created in the OS's standard temp directory, and the log file is placed in
User/Logs.