UpdaterCommon: Fix code signing error after updating on macOS #9858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents macOS from reading an old (cached) code signature on Mach-O executables.
|
I don't believe this breaks Windows, but I will check. If someone could build this PR so I can grab the artifacts, that would be great. |
|
OK, I confirmed the updater still works on Windows. For reference, I tested by downloading 5.0-14095 and 5.0-14344 from dolphin-emu.org, running my local build of the updater (for Windows, the buildbot artifact) on 5.0-14095, and comparing to 5.0-14344. Command line for Windows: macOS: |
leoetlino
approved these changes
Jul 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upon launching an app, macOS's kernel caches all code signatures from the main executable and any frameworks it uses. When the updater notices a file needs to be updated, it uses
File::Copy(), which reads the contents of the new file and writes it over the contents of the old file. This operation does not invalidate the code signature cache. Therefore, when Dolphin is launched after the update operation is complete, the cached code signature is used to validate the new files. macOS then proceeds to kill Dolphin due to a code signing error.The solution: Use Rename instead of Copy.
(Thanks to Quinn from the Apple Developer Forums for making a post about this quirk.
Also, this PR only fixes one issue with the macOS updater. If the bundle has the
com.apple.quarantinexattr set, then the updater may fail to launch. #8915 fixes this issue.)