Port some settings to the new config system #8976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iwubcode
approved these changes
Jul 23, 2020
BhaaLseN
reviewed
Jul 23, 2020
| @@ -94,7 +95,7 @@ void AddMessage(std::string message, u32 ms, u32 rgba) | |||
|
|
|||
| void DrawMessages() | |||
| { | |||
| const bool draw_messages = SConfig::GetInstance().bOnScreenDisplayMessages; | |||
| const bool draw_messages = Config::Get(Config::MAIN_OSD_MESSAGES); | |||
There was a problem hiding this comment.
Is this a potentially time-sensitive location that could use some caching (and a hook into the config changed callback)? Feels like this might be called fairly often (like every frame or so).
There was a problem hiding this comment.
I believe this is called exactly once a frame. I've assumed that running this 60 times a second wouldn't have any noticeable impact.
There was a problem hiding this comment.
Thinking of #8884 somewhere in the back of my mind, which seemed similar. Didn't test (nor profile) it though, so I'm just guessing from staring at the code.
Other than the controller settings and JIT debug settings, these are the only settings which were defined in Java code but not defined in the new config system in C++. (There are still a lot of settings that are defined in the new config system but not yet saveable in the new config system, though.)
JosJuice
force-pushed
the
port-some-settings
branch
from
e37919c
to
b0f9bb9
Compare
lioncash
approved these changes
Sep 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split out from the Android PR #8975.
Other than the controller settings and JIT debug settings, these are the only settings which were defined in Java code but not defined in the new config system in C++. (There are still a lot of settings that are defined in the new config system but not yet saveable in the new config system, though.)