Improve behavior of savestates made while game is assuming the state of the inserted memory card. #9027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lioncash
reviewed
Aug 11, 2020
AdmiralCurtiss
force-pushed
the
memcard-savestate-paranoia
branch
from
f4dc5a6
to
5a775fb
Compare
BhaaLseN
reviewed
Aug 12, 2020
AdmiralCurtiss
force-pushed
the
memcard-savestate-paranoia
branch
2 times, most recently
from
26f5d7d
to
c8f027e
Compare
AdmiralCurtiss
force-pushed
the
memcard-savestate-paranoia
branch
from
c8f027e
to
07a1542
Compare
|
Considering this prevents save corruption, we should merge this once it is reviewed and good to go. |
AdmiralCurtiss
force-pushed
the
memcard-savestate-paranoia
branch
from
07a1542
to
57964e0
Compare
|
Is this still planning to be merged? |
|
Considering I've yet to see anyone yell about corrupted savedata in the many years this issue has potentially existed, it's probably not particularly critical. If you want to merge it sure, if not eh, that's probably okay. I'll rebase it tomorrow just in case. |
AdmiralCurtiss
force-pushed
the
memcard-savestate-paranoia
branch
from
57964e0
to
337b0d4
Compare
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://bugs.dolphin-emu.org/issues/12220
This looks pretty convoluted but I hope the comments make it clear what's happening and why.