Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated SoundTouch library to 1.8.1 [r198] #953

Merged
merged 1 commit into from Sep 4, 2014

Conversation

skidau
Copy link
Contributor

@skidau skidau commented Sep 3, 2014

Updated the time stretch library to the latest revision and selected the linear algorithm for interpolation. Seems to respond better to a dynamically changing framerate.

@JMC47
Copy link
Contributor

JMC47 commented Sep 3, 2014

This will allow OpenAL to have a better time stretch option? I'll test it through and see what I can find.

@skidau
Copy link
Contributor Author

skidau commented Sep 3, 2014

Yes, it seems to be better. The build can be tested here (needs OpenAL backend selected):

https://dl.dolphin-emu.org/prs/pr-953-dolphin-latest-x64.7z
https://dl.dolphin-emu.org/prs/pr-953-dolphin-latest.dmg

@shuffle2
Copy link
Contributor

shuffle2 commented Sep 3, 2014

Shouldn't this be one commit? It looks like the second one is also just updating files in externals...are there any remaining parts that aren't updated for soundtouch?

@skidau
Copy link
Contributor Author

skidau commented Sep 3, 2014

I split the commit to signify that the second commit is a Dolphin specific modification of the original source code. I kept the changes that were needed for the code to compile in the first commit.

@lioncash
Copy link
Member

lioncash commented Sep 3, 2014

@skidau Does the SoundTouch API not allow you to specify that though during initialization or something? I'm just saying in case in the future if we update it again, if it isn't you doing it, someone might not know about that slight modification.

@shuffle2
Copy link
Contributor

shuffle2 commented Sep 3, 2014

@skidau ok, I guess the Externals/soundtouch/SoundTouch.h change should still be in the first commit though? and also, what @lioncash said...if it's not configurable, can you add a comment or some notes in a text file (current version, changes, etc).

@skidau
Copy link
Contributor Author

skidau commented Sep 4, 2014

@lioncash, on closer inspection the configuration change was for a feature that Dolphin does not use. I have removed the second commit. This PR is ready for review.

@lioncash
Copy link
Member

lioncash commented Sep 4, 2014

@skidau Looks good to me now, feel free to merge.

skidau added a commit that referenced this pull request Sep 4, 2014
Updated SoundTouch library to 1.8.1 [r198]
@skidau skidau merged commit e732f27 into dolphin-emu:master Sep 4, 2014
@skidau skidau deleted the soundtouch-180 branch September 4, 2014 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants