Proposed fix: Fix through associations on join tables

[pcsanwald]

The current problem with adding attributes to join tables is due to the following change in sequelize:

v3:
group.addUser( alice, { role: 'member' });

v4:
group.addUser( alice, { through: { role: 'member' }});

I've forked the repo, upgraded sequelize, made the required fix. I'm happy to open a PR for this repo, if you are ok with dropping support for sequelize v3. Thoughts?

[sevarubbo]

Please do!

[seahyc]

Yup, would appreciate it greatly!

[hugodes]

Yes, we're left hanging on our update to v4, please submit a PR.
@pcsanwald could you provide a link to your fork so we can use it on our project in the meantime ?
cheers

[pcsanwald]

Sorry everyone, will submit a PR in a couple hours Best,

…

--paul

On Nov 28, 2017, 1:51 AM -0800, Hugo Des ***@***.***>, wrote: Yes, we're left hanging on our update to v4, please submit a PR. @pcsanwald could you provide a link to your fork so we can use it on our project in the meantime ? cheers — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[pcsanwald]

@sevarubbo @hugodes @seahyc this is addressed in PR #84

[hugodes]

@domasx2 could you release this with a version bump please ?

[domasx2]

Done, 0.7.0