Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load performance #52

Closed
mattbrownfaro opened this issue Aug 18, 2022 · 4 comments · Fixed by #53
Closed

Load performance #52

mattbrownfaro opened this issue Aug 18, 2022 · 4 comments · Fixed by #53
Labels
feature New feature added help wanted Extra attention is needed

Comments

@mattbrownfaro
Copy link

Hi Albert,

I'm running into a pretty big issue regarding load time. I have a 74K object count DWG that takes over 300 seconds to load in AS. Lots of small lines in this drawing. I could send you the DWG if interested.

Also, is there a timeline for when Polyline save will be implemented?

Thank you,
Matt

@DomCR DomCR added the help wanted Extra attention is needed label Aug 19, 2022
@DomCR
Copy link
Owner

DomCR commented Aug 19, 2022

Hi @mattbrownfaro,

The low performance when reading a DWG may be due the flag DwgReaderFlags.CheckCrc, make sure that this flag is disabled in the DwgReader, by default is not set.

If the issue continue I'll open a branch to implement stress tests to explore the issue.

About the topic for write a Polyline, I'll open a dedicated branch to implement it.

@DomCR DomCR added the feature New feature added label Aug 19, 2022
@DJGosnell
Copy link
Contributor

The low performance when reading a DWG may be due the flag DwgReaderFlags.CheckCrc, make sure that this flag is disabled in the DwgReader, by default is not set.

This was also my experience with loading files.

I feel like there are some other avenues I can pursue to increase the loading & saving performance, I just have to make some time.

@mattbrownfaro
Copy link
Author

Thank you Albert. I'll try out the flag and report back.

@mattbrownfaro
Copy link
Author

I had the flag set to none. I set it to CheckCrc just for curiosity and it was quite a bit slower as expected.

@DomCR DomCR linked a pull request Aug 27, 2022 that will close this issue
@DomCR DomCR closed this as completed in #53 Aug 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature added help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants