Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nuget Package #4

Closed
ds5678 opened this issue Sep 20, 2021 · 6 comments
Closed

Nuget Package #4

ds5678 opened this issue Sep 20, 2021 · 6 comments

Comments

@ds5678
Copy link

ds5678 commented Sep 20, 2021

Hi! This is awesome what you're doing here. I was thinking about maybe using your MeshIO.FBX in my AssetRipper project. Would you be willing to publish a nuget package for it?

@DomCR
Copy link
Owner

DomCR commented Sep 23, 2021

Hi @ds5678,

thanks for the suggestion, I'll look to release the first version of this library in NugetPackage.
The project is in an early stage, but if you start using it and you find any bug, error or an idea to add as a feature don doubt to open an issue.

@ds5678
Copy link
Author

ds5678 commented Sep 23, 2021

Hi Dom, do you have Discord? There's a link to my server on AssetRipper repository page. If you're willing, I would like to pass some thoughts back and forth. https://discord.gg/XqXa53W2Yh

@DomCR
Copy link
Owner

DomCR commented Oct 5, 2021

Hi @ds5678,
I've publish the first version of the Package, notice that is an alpha version and there is only the fbx library.

@ds5678
Copy link
Author

ds5678 commented Oct 8, 2021

Hi @DomCR, I've gotten a chance to thoroughly look at this, and I like what you have so far. I have some thoughts and questions:

  1. I need to be able to write FBX to a stream, which may require changes to FbxWriter.
  2. Can we separate things so there's only ever one class per file?
  3. Can CSUtilities be removed?
  4. Can the classes in MeshIO.Math be replaced with correspondents from System.Numerics?
  5. Are you open to STL support?
  6. Can MeshIO.Elements.Geometries.Mesh inherit the name constructor from Geometry?
  7. Can we remove all the unnecessary using System... in the project?

I, of course, am willing to do any or all of these.

@ds5678
Copy link
Author

ds5678 commented Oct 17, 2021

@DomCR Do you have an opinion on these changes?

@DomCR
Copy link
Owner

DomCR commented Oct 17, 2021

Hi @ds5678, sorry for the delay, answering your questions:

  1. I need to be able to write FBX to a stream, which may require changes to FbxWriter.
    Done!
  2. Can we separate things so there's only ever one class per file?
    Yes, this should be mandatory, but by now when I'm implementing sometimes I forget to separate the classes.
  3. Can CSUtilities be removed?
    The library has been added as a submodule, so you don't need to Fork the repository, just pull the last changes. The library has some shared classes in my other repositories so I will keep the CSUtilities in the project.
  4. Can the classes in MeshIO.Math be replaced with correspondents from System.Numerics?
    I prefer not, System.Numerics use floats and I prefer to have the control over the structures to store the values. The structures are very similar so it would be easy to implement a bridge library between this two.
  5. Are you open to STL support?
    Yea, I'll look into it, but for me is not a priority right now.
  6. Can MeshIO.Elements.Geometries.Mesh inherit the name constructor from Geometry?
    This kind of errors are are because is a WIP library, it should inherit the constructor.
  7. Can we remove all the unnecessary using System... in the project?
    The project is meant to be compatible with net48, NET Core 5 and NET Standard 2.1, the libraries that are in the Project seem to be locked, but I'll try to remove them.

@ds5678 ds5678 closed this as completed Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants