Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Majority of LibP2P requests fail under load #1799

Closed
mibuono opened this issue May 29, 2024 · 4 comments
Closed

Majority of LibP2P requests fail under load #1799

mibuono opened this issue May 29, 2024 · 4 comments
Assignees
Labels
bug Something isn't working libp2p Issues related to the libp2p refactor

Comments

@mibuono
Copy link

mibuono commented May 29, 2024

Majority Libp2p Requests don’t get a response under load

This causes syncing to not work and in some cases nodes that get out of sync dont come back

Steps to reproduce

There are two ways.

  1. Run a network without transactions but drop half the requests, so that the request manager gets activated and used
  2. Run a network with transactions and under high load of 1000tps+ you can observe this Or try to sync against the garden test which has that tps

You will see lots of requests timing out and not going through as well and lots of empty messages

@mibuono mibuono added bug Something isn't working libp2p Issues related to the libp2p refactor labels May 29, 2024
@gameofpointers
Copy link
Contributor

gameofpointers commented May 29, 2024

WARNING[05-29|16:54:30.637] Peer did not respond in time                  peerId
=12D3KooWRQrLVEeJtfyKoJDYWYjryBKR8qxkDooMMzyf2ZpLaZRR requestID=3710988829
ERROR  [05-29|16:54:30.637] Error requesting the data from peer           err="p
eer did not respond in time" peerId=12D3KooWRQrLVEeJtfyKoJDYWYjryBKR8qxkDooMMzyf
2ZpLaZRR topic=0xcc765ce0d79736950aeded81e32bbd55a03c4dcec236c1944da32609a237fad
c/0/blocks

Some of the errors seen trying to request

ERROR  [05-29|16:57:04.987] unsupported quai message type                 quaiMsg=
ERROR  [05-29|16:57:04.987] unsupported quai message type                 quaiMsg=
ERROR  [05-29|16:57:05.005] unsupported quai message type                 quaiMsg=
ERROR  [05-29|16:57:05.005] unsupported quai message type                 quaiMsg=

@wizeguyy
Copy link
Member

wizeguyy commented Jun 3, 2024

This is blocked waiting on the following information:

  1. logs containing request path instrumentation prints @gameofpointers @mechanikalk
  2. commit hash of commit which previously was able to sync @mechanikalk

Also blocked by bootstrapping errors which prevent my node from joining the network: #1805

@wizeguyy
Copy link
Member

wizeguyy commented Jun 3, 2024

According to @mechanikalk, 31bd59b was able to sync

@gameofpointers
Copy link
Contributor

@mibuono @wizeguyy I am taking this ticket over, i worked on it yesterday and i think have found the root cause and fixed it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working libp2p Issues related to the libp2p refactor
Projects
None yet
Development

No branches or pull requests

3 participants