bug correction in hardware web page and refactoring #1148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks!, But because all of the refactoring i can not nee the bug you corrected... |
|
When I modified the hardware description from "MyHome OpenWebNet" to "MyHome OpenWebNet with LAN interface" as you asked me, I didn't realize that the conditions text.indexOf("MyHome OpenWebNet with LAN interface") >= 0 in HardwareController.js where not reached because there was a condition text.indexOf("LAN") >= 0 before. On the forum, I saw that spugna85 complianed about
not seeing password field anymore in the hardware page, making it impossible to use some gateways. Thus, I merged the actions for text.indexOf("MyHome OpenWebNet with LAN interface") >= 0 condition and text.indexOf("LAN") >= 0 && xxx. As the conditions were rather complicated, I grouped them similarly to what is done for textindexOf("USB")>=0, where there is a first condition "USB" then there are more specialized conditions "USB and MySensors", "USB and P1 Smart Meter" and so on.
…________________________________
De : gizmocuz <notifications@github.com>
Envoyé : dimanche 22 janvier 2017 13:19
À : domoticz/domoticz
Cc : stéphane; Author
Objet : Re: [domoticz/domoticz] bug correction in hardware web page and refactoring (#1148)
Thanks!, But because all of the refactoring i can not nee the bug you corrected...
Could you explain this ?
-
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#1148 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AQLFbNPeCZ8ovxUyw4lAn47_62Rbka9Cks5rU1dTgaJpZM4LqGL_>.
|
|
Thanks! |
|
@steplebr, can you check your changes for the Xiaomi Gateway on the hardware page? It should have options for IP address, port, and password. I'm no longer seeing these fields after this update. |
|
Had to revert your patch as it caused issues. see reverted merge and forum topic: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.