Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return the webhook URL as part of the Webhook info #7

Closed
hurngchunlee opened this issue Mar 11, 2019 · 4 comments
Closed

Return the webhook URL as part of the Webhook info #7

hurngchunlee opened this issue Mar 11, 2019 · 4 comments

Comments

@hurngchunlee
Copy link
Member

@rutgervandeelen

It's nice to see that you return whatever in the database Item back as the information; but I miss the full Webhook URL which needs to be constructed by taking the Hash of the Webhook and the base URL of the webhook trigger. Please also provide it as part of the returned Webhook info.

https://github.com/Donders-Institute/hpc-qaas/blob/96650f36c11ec6adb4aa0f1faa50e15a344ec6c7/internal/server/configuration.go#L28
@aardkronkel
Copy link
Contributor

aardkronkel commented Mar 11, 2019 •
edited
Loading

Done. See for example code in after commit b6f5f4f.

@hurngchunlee
Copy link
Member Author

Shouldn’t the returned URL with port 443?

@hurngchunlee hurngchunlee reopened this Mar 12, 2019
@aardkronkel
Copy link
Contributor

My mistake. Just fixed the ports in commit 630a60f.

@hurngchunlee
Copy link
Member Author

Shall we close this one? The Webhook URL is already available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hurngchunlee @aardkronkel