Add code coverage and refactor cli. #600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes Unknown when pulling 357e6d6 on cli-refactor into * on master*. |
| @@ -19,3 +19,4 @@ notifications: | |||
| - matthew@bitovi.com | |||
| on_success: change | |||
| on_failure: change | |||
| script: npm run coverage:upload | |||
There was a problem hiding this comment.
This means the guide tests are not running in Travis. We need to be able to run all of these things as well: https://github.com/donejs/donejs/blob/cli-refactor/package.json#L10
|
Changes Unknown when pulling 13685b8 on cli-refactor into * on master*. |
The binary has a different name in windows, so I changed the test to create the fake binary with the right name based on the OS it's running, also this PR changes cmd-init to it re-uses the run-binary module which has logic to handle the binary names based on the OS.
|
Changes Unknown when pulling e5a605e on cli-refactor into * on master*. |
|
@matthewp is there a way to rebuild that failing appveyor job? it seems to be a one time thing https://ci.appveyor.com/project/daffl/donejs/build/1.0.1246/job/gnfrlgaor43xgtam#L1897 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.