Initial implementation of general donejs add.

[m-mujica]

This is branched of #600, I used the original implementation by @daffl with a few changes:

• Added deprecation warnings to donejs init and donejs plugin

• Added custom usage instructions to donejs add
  

@daffl there is only one small difference with your impl, this one won't call init when the type is unknown, instead it'll complain about the invalid type value. What do you think? should I add that behaviour back? (a nicer diff 80c956e that does not include all of the refactor changes).

cc: @matthewp

[coveralls]

Changes Unknown when pulling 80c956e on donejs--add into * on master*.

[daffl]

JSHint will complain if functions are used before they are declared. We probably want to move this one to the top.

[matthewp]

I'd say jshint is wrong then :)

[daffl]

It's a pet peeve of mine, too. Imagine if this would be 1000 lines of code and I'd skim through it I have no idea what this function does until I find it somewhere later on.

[matthewp]

See, I like this style for that reason, if you have a really long function I like seeing the return early in the function body, I think it makes it easier to understand how it flows. Like:

function doSomeStuff(){
  var a = 'foo';
  var b = 'bar';

  return doOtherStuff();

  function doOtherStuff() {
    // this is a super long function
  }
}

[matthewp]

What do you think? should I add that behaviour back?

Maybe I'm not following, but when within an existing donejs app you are able to do stuff like:

donejs add cordova

Which will install and run donejs-cordova, are we removing that ability?

[daffl]

No, @justinbmeyer wanted donejs add to be used consistently. So additionally to the old functionality (donejs add component, donejs add cordova etc.) you can now initialize a new app/plugin/generator via:

donejs add app|plugin|generator [foldername]

This is in place of

donejs init [folder] # donejs add app [folder]
donejs plugin [folder] # donejs add plugin [folder]
donejs init [folder] --type generator # donejs add generator [folder]

[daffl]

Nice work! 👍

[matthewp]

So additionally to the old functionality

Yeah, I understand that, but looking at this change it looks like this breaks the old functionality. Maybe I'm misreading it, but won't this throw if you did donejs add cordova ?

[daffl]

Good catch. @m-mujica This needs to be a fall-through like it was in the original implementation (see https://github.com/donejs/donejs/blob/donejs-add/bin/donejs#L62) and I don't think it is right now.

[m-mujica]

@daffl @matthewp I added support for the original donejs add command, made some changes to the add --help output to reflect the command variations:

It should good to go now :D

[coveralls]

Changes Unknown when pulling 5fbc1c1 on donejs--add into * on master*.

[matthewp]

I have no further complaints, good work.

[matthewp]

I take that back, it looks like place-my-order guide test is still not running... very weird.

[m-mujica]

[matthewp]

So the PMO guide did run in the PR one but not in the push, don't want it to block this change, I'll take a look separately.