Skip to content
This repository has been archived by the owner on Jun 23, 2023. It is now read-only.

Remove dist/ folder #47

Closed
donmccurdy opened this issue Jan 4, 2021 · 2 comments
Closed

Remove dist/ folder #47

donmccurdy opened this issue Jan 4, 2021 · 2 comments
Assignees

Comments

@donmccurdy
Copy link
Owner

Including the dist/ folder in source control is a regular source of confusion for new contributors, because the files are modified when building or testing changes, but shouldn't be included in PRs. These files cannot be reviewed easily, and are meant to be rebuilt by an author when publishing a new release. To avoid this confusion, the dist/ folder should be added to .gitignore and explicitly added to the published files in package.json. Because it's published to NPM, it will still be available from CDNs like Unpkg.

@donmccurdy
Copy link
Owner Author

Also need to ensure that tests pass after this change, so the CI will need to run a build.

@donmccurdy
Copy link
Owner Author

Fixed in 55f5a2e.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant