-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Untracking does not remove #13
Comments
However it does work as expected in case https websites. Without https being mentioned in the input. |
Line 10 in 93520e7
Here However, it does not attempt to remove Ideally it should try to delete both the http and https websites when the schema is not mentioned in the input. |
Line 97 in 93520e7
The solution could lie in the fact that instead of returning a string Sanitise can return a structured form of the website. If structured form is returned than the consumer would be able to get both the http and https version from the same call. If structured form is returned that the caller will still need to do a line of work converting it into a string. |
Lines 88 to 89 in 93520e7
Also while at it the |
* v1.1.2 - Improve web.Sanitise * v1.1.2 - Update tests * v1.1.2 - Add error message when wrong input * v1.1.2 - Update Track * v1.1.2 - Update Untrack * v1.1.2 - Update Readme
/untrack donnieashok.in
Would not remove http://donnieashok.in
But it still responds with
Removed!
The text was updated successfully, but these errors were encountered: