Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache Cleaner Icon #1816

Closed
onuronsekiz opened this issue Nov 19, 2023 · 1 comment
Closed

Cache Cleaner Icon #1816

onuronsekiz opened this issue Nov 19, 2023 · 1 comment

Comments

@onuronsekiz
Copy link
Contributor

I have installed Cache Cleaner application from F-Droid.
Maybe it is only on my phone but arcticon for app is not shown.
There is icon in repository with correct name.
There is appfilter entries with correct item component.
Manually selecting the icon works. But it is not automatically recognized.

@TotallyAvailable
Copy link
Contributor

TotallyAvailable commented Nov 19, 2023

The entry got fixed after 8.0.6
in the release

<item component="ComponentInfo{com.github.bmx666.appcachecleaner/com.github.bmx666.appcachecleaner.ui.activity.AppCacheCleanerActivity}" drawable="cache_cleaner"

addition since

<item component="ComponentInfo{com.github.bmx666.appcachecleaner/com.github.bmx666.appcachecleaner.ui.activity.LauncherActivity}" drawable="cache_cleaner"

Might be worth adding a 'Commits since Release' link to each new Version post to allow for easy 'Find in Page'.

  • currently 8.0.6...main
  • Add a note to switch to 'Files changed'
  • Search for the icon they intend to add, or search for "(othe)r/appfilter" -> Load Diff
  • Now search for whatever Icon might be broken, if the entry doesn't yet exist open an Issue or PR, if they know the new correct Activity Name.

Slightly more advanced:

  • Link the current appfilter.xml below 'Commits since' for anyone knowing (part) of a/the PackageName. Given that not every App has a separate searchable entry within the App, this should allow to keep "piggybacked" entries, that might be broken, updated as well.
    (If someone just started using the Pack, they wouldn't know that a given Icon used to be covered that way. If they now find it by searching they can create an Icon for it themselves, provide updated information or split the entry for future visibility.)

@Donnnno Donnnno closed this as completed Nov 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants